[ecash-herald] Patch use of float vs int for sats
ClosedPublic
Actions

Authored by bytesofman on Nov 15 2023, 17:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8b57cf2fbb28: [ecash-herald] Patch use of float vs int for sats

Summary

Oversight from implementation of staking rewards parsing. parseFloat will work fine but we should parseInt as all output.value instances from chronik are expected to be strings of satoshi values, i.e. integers.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 15 2023, 17:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2023, 17:18

bytesofman requested review of this revision.Nov 15 2023, 17:18

Harbormaster completed remote builds in B25629: Diff 43098.Nov 15 2023, 17:19

Fabien accepted this revision.Nov 15 2023, 17:20

This revision is now accepted and ready to land.Nov 15 2023, 17:20

Closed by commit rABC8b57cf2fbb28: [ecash-herald] Patch use of float vs int for sats (authored by bytesofman). · Explain WhyNov 15 2023, 17:42

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC8b57cf2fbb28: [ecash-herald] Patch use of float vs int for sats.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

2 lines

Diff 43102

View Options

apps/ecash-herald/src/parse.js

[ecash-herald] Patch use of float vs int for satsClosedPublicActions