Page MenuHomePhabricator

[ecash-herald] Patch use of float vs int for sats
ClosedPublic

Authored by bytesofman on Nov 15 2023, 17:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8b57cf2fbb28: [ecash-herald] Patch use of float vs int for sats
Summary

Oversight from implementation of staking rewards parsing. parseFloat will work fine but we should parseInt as all output.value instances from chronik are expected to be strings of satoshi values, i.e. integers.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
int-not-float-for-sats
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25629
Build 50838: Build Diffecash-herald-tests
Build 50837: arc lint + arc unit