Differential D14806

[e.cash] Flesh out requirements section on staking page
ClosedPublic
Actions

Authored by Mengerian on Nov 17 2023, 05:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd82c0692dd4a: [e.cash] Flesh out requirements section on staking page

Test Plan

Ran it locally, read through the requirements

Diff Detail

Repository

rABC Bitcoin ABC

Branch

e.cash-staking-requirements

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25659
Build 50898: Build Diff
Build 50897: arc lint + arc unit

Event Timeline

Mengerian created this revision.Nov 17 2023, 05:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2023, 05:18

Mengerian requested review of this revision.Nov 17 2023, 05:18

Harbormaster completed remote builds in B25650: Diff 43136.Nov 17 2023, 05:19

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41967 for the next 60 minutes.

Fabien requested changes to this revision.Nov 17 2023, 10:36

Fabien added inline comments.

web/e.cash/pages/staking.js
59–60 ↗	(On Diff #43136)
79 ↗	(On Diff #43136)

This revision now requires changes to proceed.Nov 17 2023, 10:36

Add P2PKH requirement
Fix typo

Harbormaster completed remote builds in B25659: Diff 43149.Nov 17 2023, 15:11

Fabien accepted this revision.Nov 17 2023, 15:16

This revision is now accepted and ready to land.Nov 17 2023, 15:16

Closed by commit rABCd82c0692dd4a: [e.cash] Flesh out requirements section on staking page (authored by Mengerian). · Explain WhyNov 17 2023, 15:18

This revision was automatically updated to reflect the committed changes.

Mengerian added a commit: rABCd82c0692dd4a: [e.cash] Flesh out requirements section on staking page.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

staking.js

31 lines

Diff 43149

View Options

web/e.cash/pages/staking.js

[e.cash] Flesh out requirements section on staking pageClosedPublicActions