The return type in serialize_privkey was wrong, it is a Base58 (WIF) encoded string, not bytes.
Also base_decode may return None if the result does not fit in the expected length, and DecodeBase58Check needs to bail out early when this happens instead of trying to slice None.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCa32e077e7061: [electrum] fix and add tyephints in base58 decoding code
python test_runner.py
Check that these particular errors are now fixed wrt to mypy:
mypy --ignore-missing-imports | grep "^electrumabc/bitcoin.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- auxkey_incrementing
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25654 Build 50888: Build Diff electrum-tests Build 50887: arc lint + arc unit