Page MenuHomePhabricator

[chronik-client] Generate proto file for in-node chronik
ClosedPublic

Authored by bytesofman on Nov 17 2023, 20:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaa10724d2e84: [chronik-client] Generate proto file for in-node chronik
Summary

The proto file for the in-node version of chronik is generated from the in-node proto file in the monorepo.

Note: The legacy build-proto script is dependent on running the command from a local repo with bitcoinsuite in the correct place. It should not remain in the monorepo codebase. Updates to the NNG chronik version are not anticipated in the monorepo. If they do occur, the dependencies need to be pulled in in some other way anyway, so the script should still go.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

name the generated file specific to in-node chronik

Fabien added a subscriber: Fabien.
Fabien added inline comments.
modules/chronik-client/package.json
10 ↗(On Diff #43160)

Is the path relative to this file or to the caller working directory ?

This revision is now accepted and ready to land.Nov 19 2023, 19:24