Paths

Table of Contentst

Differential D14814

[chronik-client] Generate proto file for in-node chronik
ClosedPublic
Actions

Authored by bytesofman on Nov 17 2023, 20:24.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCaa10724d2e84: [chronik-client] Generate proto file for in-node chronik

Summary

The proto file for the in-node version of chronik is generated from the in-node proto file in the monorepo.

Note: The legacy build-proto script is dependent on running the command from a local repo with bitcoinsuite in the correct place. It should not remain in the monorepo codebase. Updates to the NNG chronik version are not anticipated in the monorepo. If they do occur, the dependencies need to be pulled in in some other way anyway, so the script should still go.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

proto-script-up

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25667
Build 50914: Build Diff	chronik-client-tests
Build 50913: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 17 2023, 20:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2023, 20:24

bytesofman requested review of this revision.Nov 17 2023, 20:24

Harbormaster completed remote builds in B25666: Diff 43159.Nov 17 2023, 20:25

name the generated file specific to in-node chronik

Harbormaster completed remote builds in B25667: Diff 43160.Nov 17 2023, 20:30

Fabien accepted this revision.Nov 19 2023, 19:24

Fabien added a subscriber: Fabien.

Fabien added inline comments.

modules/chronik-client/package.json
10	Is the path relative to this file or to the caller working directory ?

This revision is now accepted and ready to land.Nov 19 2023, 19:24

Closed by commit rABCaa10724d2e84: [chronik-client] Generate proto file for in-node chronik (authored by bytesofman). · Explain WhyNov 20 2023, 17:24

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCaa10724d2e84: [chronik-client] Generate proto file for in-node chronik.

bytesofman mentioned this in D14758: [chronik-client] [DRAFT] Support in-node chronik.Nov 21 2023, 21:37

Revision Contents
Changeset List

Path

Size

modules/

chronik-client/

2 lines

proto/

2814 lines

Diff 43160

modules/chronik-client/package.json

Loading...

modules/chronik-client/proto/chronikNode.ts

Loading...