Page MenuHomePhabricator

[Cashtab] app.js format improvements
ClosedPublic

Authored by bytesofman on Nov 20 2023, 20:12.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC8270010d754c: [Cashtab] app.js format improvements
Summary

Match extension and non-extension app.js files where they are not expected to diverge

Have been evaluating removing the use of two separate files for extension and non-extension, and writing the code so that the files are parsed differently at buildtime e.g. using an env variable to build the extension. Running into some barriers with this approach but, either way, there is some whitespace to remove in the extension file, and legacy capitalization to fix in the non-extension file

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
extension-app-files-streamline
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25686
Build 50952: Build Diffcashtab-tests
Build 50951: arc lint + arc unit