Paths

Table of Contentst

Differential D14829

Use std::chrono for the time to rotate destination of addr messages + tests
ClosedPublic
Actions

Authored by PiRK on Nov 21 2023, 15:27.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2db7298bc3cd: Use std::chrono for the time to rotate destination of addr messages + tests

Summary

Before this change, 24 hours was defined as uint. I replaced it with std::chrono, which is mockable and type-safe.

Check that within 24h addr of a given node is forwarded to the same peer(s), and then the destination is rotated every 24h.

Co-authored-by: Jon Atack <jon@atack.com>

This is a backport of core#18642

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 21 2023, 15:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2023, 15:27

PiRK requested review of this revision.Nov 21 2023, 15:27

teamcity edited the summary of this revision. (Show Details)Nov 21 2023, 15:27

Harbormaster completed remote builds in B25694: Diff 43199.Nov 21 2023, 16:19

Fabien accepted this revision.Nov 21 2023, 16:24

This revision is now accepted and ready to land.Nov 21 2023, 16:24

Closed by commit rABC2db7298bc3cd: Use std::chrono for the time to rotate destination of addr messages + tests (authored by Gleb Naumenko <naumenko.gs@gmail.com>, committed by PiRK). · Explain WhyNov 22 2023, 11:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2db7298bc3cd: Use std::chrono for the time to rotate destination of addr messages + tests.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

11 lines

test/

functional/

p2p_addr_relay.py

81 lines

Diff 43214

View Options

src/net_processing.cpp