Differential D14837

[avalanche] Fix a couple issue from D14833
ClosedPublic
Actions

Authored by Fabien on Nov 22 2023, 15:33.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC24f28152ae13: [avalanche] Fix a couple issue from D14833

Summary

The log from D14833 fails on some platforms due to path to string conversion, and the chronik test fails due to the persistent avapeers messing with the quorum.

Test Plan

With chronik:

ninja all check-all

Cross build for windows

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_string_debug

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25704
Build 50988: Build Diff	lint-circular-dependencies · build-clang · build-diff · build-clang-tidy · build-debug · build-without-wallet
Build 50987: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 22 2023, 15:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2023, 15:33

Fabien requested review of this revision.Nov 22 2023, 15:33

@bot build-win64 build-linux64

teamcity awarded a token.Nov 22 2023, 15:33

Harbormaster completed remote builds in B25704: Diff 43217.Nov 22 2023, 15:51

Fabien retitled this revision from [avalanche] Fix a couple issue from D14833 The log from D14833 fails on some platforms due to path to string conversion, and the chronik test fails due to the persistent avapeers messing with the quorum. to [avalanche] Fix a couple issue from D14833.Nov 22 2023, 16:25

Fabien edited the summary of this revision. (Show Details)

PiRK accepted this revision.Nov 22 2023, 18:55

This revision is now accepted and ready to land.Nov 22 2023, 18:55

Closed by commit rABC24f28152ae13: [avalanche] Fix a couple issue from D14833 (authored by Fabien). · Explain WhyNov 22 2023, 19:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC24f28152ae13: [avalanche] Fix a couple issue from D14833.