Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC87143a692fb5: [ecash-herald] Show peerName for staking reward winner, if available

Summary

Show avalanche peerName of staking rwd winner if available

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-peer-names

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25714
Build 51008: Build Diff	ecash-herald-tests
Build 51007: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 23 2023, 12:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2023, 12:41

revert axios upgrade, was done troubleshooting

remove test script, fix comment

remove unrelated line break, mark peername api mock as generated

Harbormaster completed remote builds in B25714: Diff 43233.Nov 23 2023, 12:47

or if the API fails

apps/ecash-herald/test/mocks/block.js
1 ↗	(On Diff #43235)	this is a generated file, but it is also expected to change when we change things about msgs and the mocked blocks

Harbormaster completed remote builds in B25715: Diff 43234.Nov 23 2023, 12:48

Harbormaster completed remote builds in B25716: Diff 43235.

Harbormaster completed remote builds in B25717: Diff 43236.

Fabien requested changes to this revision.Nov 23 2023, 16:45

Fabien added a subscriber: Fabien.

Fabien added inline comments.

apps/ecash-herald/src/parse.js
1251 ↗	(On Diff #43235)	remove
1622 ↗	(On Diff #43235)	Does it properly displays the emojis ?
apps/ecash-herald/src/utils.js
91 ↗	(On Diff #43235)	You're calling avalanche.cash. I know that's the same backend but it's confusing

This revision now requires changes to proceed.Nov 23 2023, 16:45

Clarify peername source, add unit test for emoji peername, remove unused param

bytesofman marked an inline comment as done.Nov 23 2023, 17:04

bytesofman added inline comments.

apps/ecash-herald/src/parse.js
1622 ↗	(On Diff #43235)	yes, verified in mock block unit test

Harbormaster completed remote builds in B25721: Diff 43242.Nov 23 2023, 17:05

Please take care to do a proper self review before submitting a diff. This has 6 revisions...

This revision is now accepted and ready to land.Nov 23 2023, 20:38

Closed by commit rABC87143a692fb5: [ecash-herald] Show peerName for staking reward winner, if available (authored by bytesofman). · Explain WhyNov 24 2023, 02:20

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC87143a692fb5: [ecash-herald] Show peerName for staking reward winner, if available.

[ecash-herald] Show peerName for staking reward winner, if available
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43233

apps/ecash-herald/config.js

apps/ecash-herald/package-lock.json

apps/ecash-herald/package.json

apps/ecash-herald/scripts/generateMock.js

apps/ecash-herald/scripts/getRecentStakers.js

apps/ecash-herald/scripts/sendMsgByBlock.js

apps/ecash-herald/src/events.js

apps/ecash-herald/src/parse.js

apps/ecash-herald/src/utils.js

apps/ecash-herald/test/chronikWsHandler.test.js

apps/ecash-herald/test/events.test.js

apps/ecash-herald/test/fixtures/peerNames.js

apps/ecash-herald/test/mocks/block.js

apps/ecash-herald/test/mocks/recentStakersApiResponse.js

apps/ecash-herald/test/parse.test.js

apps/ecash-herald/test/utils.test.js

[ecash-herald] Show peerName for staking reward winner, if availableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43233

apps/ecash-herald/config.js

apps/ecash-herald/package-lock.json

apps/ecash-herald/package.json

apps/ecash-herald/scripts/generateMock.js

apps/ecash-herald/scripts/getRecentStakers.js

apps/ecash-herald/scripts/sendMsgByBlock.js

apps/ecash-herald/src/events.js

apps/ecash-herald/src/parse.js

apps/ecash-herald/src/utils.js

apps/ecash-herald/test/chronikWsHandler.test.js

apps/ecash-herald/test/events.test.js

apps/ecash-herald/test/fixtures/peerNames.js

apps/ecash-herald/test/mocks/block.js

apps/ecash-herald/test/mocks/recentStakersApiResponse.js

apps/ecash-herald/test/parse.test.js

apps/ecash-herald/test/utils.test.js

[ecash-herald] Show peerName for staking reward winner, if available
ClosedPublic
Actions

Revision Contents
Changeset List