[electrum] move-only: move the early exit conditions before the broadcast functions in broadcast_transaction
ClosedPublic
Actions

Authored by PiRK on Nov 24 2023, 11:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9118e60b71ca: [electrum] move-only: move the early exit conditions before the broadcast…

Summary

No need to define broadcast_thread or and broadcast_done local functions if we are not going to use them because there is no network or the fee is too low.

Depends on D14847

Test Plan

send a transaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 24 2023, 11:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2023, 11:51

PiRK requested review of this revision.Nov 24 2023, 11:51

Harbormaster completed remote builds in B25728: Diff 43253.Nov 24 2023, 11:53

PiRK edited the summary of this revision. (Show Details)Nov 24 2023, 11:54

Fabien accepted this revision.Nov 24 2023, 12:57

This revision is now accepted and ready to land.Nov 24 2023, 12:57

rebase

Harbormaster completed remote builds in B25734: Diff 43260.Nov 24 2023, 15:07

Closed by commit rABC9118e60b71ca: [electrum] move-only: move the early exit conditions before the broadcast… (authored by PiRK). · Explain WhyNov 24 2023, 21:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9118e60b71ca: [electrum] move-only: move the early exit conditions before the broadcast….

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

main_window.py

82 lines

Diff 43266

View Options

electrum/electrumabc_gui/qt/main_window.py

[electrum] move-only: move the early exit conditions before the broadcast functions in broadcast_transactionClosedPublicActions