Page MenuHomePhabricator

[chronik-client] Default true for websocket keepAlive
ClosedPublic

Authored by bytesofman on Nov 24 2023, 21:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0935ae6f5067: [chronik-client] Default true for websocket keepAlive
Summary

Plan on using this on all apps that I use chronik websockets with. It would be weirder to not want to use it.

So, the default should be true.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
keepalive-default-true
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25739
Build 51058: Build Diffchronik-client-tests
Build 51057: arc lint + arc unit

Event Timeline

bytesofman updated this revision to Diff 43268.

Modify unit tests so that keepAlive = false is tested

This revision is now accepted and ready to land.Nov 24 2023, 21:50