Page MenuHomePhabricator
Differential D14862

[net processing] Move mapNodeState into PeerManagerImpl
ClosedPublic
Actions

Authored by PiRK on Nov 28 2023, 14:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6e2be260e810: [net processing] Move mapNodeState into PeerManagerImpl
Summary

Also move a couple of BitcoinABC functions into PeerManagerImpl because they require access to State

This is a partial backport of core#24543
https://github.com/bitcoin/bitcoin/pull/24543/commits/37ecaf3e7a028486a0a1c9b717e8eb4214215805

Depends on D14861

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 28 2023, 14:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2023, 14:01
PiRK requested review of this revision.Nov 28 2023, 14:01
teamcity edited the summary of this revision. (Show Details)Nov 28 2023, 14:01
PiRK added a child revision: D14863: [net processing] Move nPreferredDownload into PeerManagerImpl.Nov 28 2023, 14:03
Harbormaster completed remote builds in B25753: Diff 43286.Nov 28 2023, 14:22
Fabien accepted this revision.Nov 29 2023, 10:14
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.cpp
956 ↗(On Diff #43286)

dito

src/net_processing.h
117 ↗(On Diff #43286)

layout

This revision is now accepted and ready to land.Nov 29 2023, 10:14
PiRK updated this revision to Diff 43308.Nov 29 2023, 10:42

doxygen comment layout

Harbormaster completed remote builds in B25771: Diff 43308.Nov 29 2023, 11:02
Closed by commit rABC6e2be260e810: [net processing] Move mapNodeState into PeerManagerImpl (authored by dergoegge <n.goeggi@gmail.com>, committed by PiRK). · Explain WhyNov 29 2023, 11:38
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6e2be260e810: [net processing] Move mapNodeState into PeerManagerImpl.

Revision Contents
Changeset List

Diff 43311

View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...