[mock-chronik-client] Update syntax to match chronik-client 0.9.0
ClosedPublic
Actions

Authored by bytesofman on Nov 29 2023, 00:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC04475ca612f1: [mock-chronik-client] Update syntax to match chronik-client 0.9.0

Summary

Update mock-chronik-client to match latest syntax. Add a unit test to confirm ws.subs is now supported.

Note: ChronikClient no longer has _url and _wsUrl properties. These are removed. These were not used in tests, but were included as a way of referencing that this was a mock chronik client and not an actual, connected chronik client. imo not really a value add, but now also incorrect, so has to go.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

update-mock-chronik-client

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25765
Build 51110: Build Diff
Build 51109: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 29 2023, 00:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2023, 00:29

bytesofman requested review of this revision.Nov 29 2023, 00:29

Harbormaster completed remote builds in B25765: Diff 43300.Nov 29 2023, 00:29

Note: these changes cause unit tests to fail in apps/ecash-herald and apps/alias-server. This diff does not change anything about the prod behavior of these apps. These failures are expected until D14869 and D14870, which upgrade chronik-client in these apps, land.

This mock is also used by Cashtab and apps/examples unit tests -- however these changes do not cause any failures there.

bytesofman mentioned this in D14860: [alias] Update the alias server to use the new chronik client with automated backup.Nov 29 2023, 00:36

Fabien accepted this revision.Nov 29 2023, 08:58

This revision is now accepted and ready to land.Nov 29 2023, 08:58

Closed by commit rABC04475ca612f1: [mock-chronik-client] Update syntax to match chronik-client 0.9.0 (authored by bytesofman). · Explain WhyNov 29 2023, 18:20

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC04475ca612f1: [mock-chronik-client] Update syntax to match chronik-client 0.9.0.