Differential D14881

refactor: Improve thread safety analysis by propagating some negative capabilities
ClosedPublic
Actions

Authored by PiRK on Nov 30 2023, 13:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC45c31d03c25a: refactor: Improve thread safety analysis by propagating some negative…

Summary

This is a backport of core#25175

Test Plan

cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check-all

cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-Wthread-safety-negative"
ninja 2>&1 | grep "(m_tx_relay_mutex|m_most_recent_block_mutex)"

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 30 2023, 13:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2023, 13:46

PiRK requested review of this revision.Nov 30 2023, 13:46

teamcity edited the summary of this revision. (Show Details)Nov 30 2023, 13:46

Harbormaster completed remote builds in B25780: Diff 43331.Nov 30 2023, 14:03

Fabien accepted this revision.Nov 30 2023, 15:47

This revision is now accepted and ready to land.Nov 30 2023, 15:47

Closed by commit rABC45c31d03c25a: refactor: Improve thread safety analysis by propagating some negative… (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyNov 30 2023, 17:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC45c31d03c25a: refactor: Improve thread safety analysis by propagating some negative….

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

20 lines

Diff 43334

View Options

refactor: Improve thread safety analysis by propagating some negative capabilitiesClosedPublicActions