Page MenuHomePhabricator
Differential D14886

[Cashtab][Alias] Update notification icon upon unavailable result from Check Alias button
AbandonedPublic
Actions

Authored by emack on Dec 1 2023, 07:53.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Summary

As per UAT feedback in T3363, pressing the Check Alias button on a registered alias should not result in a notification with a green tick icon. This diff switches it to a red cross in the form of an error notification.

image.png (489×830 px, 83 KB)

Test Plan

Check Alias on a registered alias and ensure the red cross icon is displayed
Check Alias on an unregistered alias and ensure the green tick icon is displayed
Check Alias on a pending alias and ensure the green tick icon is displayed

Diff Detail

Repository
rABC Bitcoin ABC
Branch
aliasCheckIcon
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25785
Build 51150: Build Diffcashtab-tests
Build 51149: arc lint + arc unit

Event Timeline

emack created this revision.Dec 1 2023, 07:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2023, 07:53
emack requested review of this revision.Dec 1 2023, 07:53
emack edited the summary of this revision. (Show Details)Dec 1 2023, 07:55
Harbormaster completed remote builds in B25785: Diff 43338.Dec 1 2023, 07:56
Fabien accepted this revision.Dec 1 2023, 09:24
Fabien added a subscriber: Fabien.

Might not be needed depending on D14885 but otherwise looks good

This revision is now accepted and ready to land.Dec 1 2023, 09:24
emack abandoned this revision.Dec 1 2023, 10:56

Deprecating check alias in another diff

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Alias/
4 lines

Diff 43338

View Options

cashtab/src/components/Alias/Alias.js

Loading...