Page MenuHomePhabricator

Move handling of unconnecting headers into own function
ClosedPublic

Authored by PiRK on Dec 5 2023, 11:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe70a075264b1: Move handling of unconnecting headers into own function
Summary

This introduces a minor change in the misbehavior score: previously a non-connecting non-continuous header sequence of size MAX_BLOCKS_TO_ANNOUNCE+1 was assigned 20 (non-continuous headers sequence), now it is assigned 10 (invalid header received).
The behavior is unchanged if the number of headers is <= MAX_BLOCKS_TO_ANNOUNCE.

This is a partial backport of core#25454
https://github.com/bitcoin/bitcoin/pull/25454/commits/7f2450871b3ea0b4d02d56bd2ca365fcc25cf90e

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable