Page MenuHomePhabricator

[Cashtab][Alias] Update the alias available input message
ClosedPublic

Authored by emack on Dec 6 2023, 01:29.

Details

Summary

Per UAT feedback, color the alias length/price message as eCashBlue to be consistent with the purple 'alias is taken' error message for the alias input field. The message itself is also updated to be more obvious this is available.

image.png (251×556 px, 25 KB)

Existance of pending alias warning is still handled in the subsequent confirmation modal as usual.

Test Plan

npm test
npm start
Input an invalid alias and ensure the input validation error is triggered
Input a valid registered alias and ensure the existing alias is taken error is displayed
Input a valid unregistered alias and ensure the This (length) byte alias is available, (price) XEC to register. is displayed in eCashBlue.
Make sure there is at least one pending alias for this wallet and then click Register on the same pending alias and ensure no regression to the pending warning on the subsequent confirmation modal.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested review of this revision.Dec 6 2023, 01:29

judgment call but what about ecash blue instead of green?

the green is kinda jarring, not part of the color pallet, weird to see

emack planned changes to this revision.Dec 6 2023, 04:52

Switched alias availability color from vomit green to eCash blue in order to align with the Cashtab's color scheme

image.png (251×556 px, 25 KB)

emack edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Dec 6 2023, 08:52