Remove unecessary calls to GetSatoshis and Amount creation.
ClosedPublic
Actions

Authored by deadalnix on Jun 9 2018, 12:44.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING49a8cb7b4e0a: Remove unecessary calls to GetSatoshis and Amount creation.
rABC49a8cb7b4e0a: Remove unecessary calls to GetSatoshis and Amount creation.

Summary

As per title. No need to prematurely drop typing when not necessary.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 9 2018, 12:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2018, 12:44

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Add some obiously overlooked instance.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2723: Diff 4096.Jun 9 2018, 13:19

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2724: Diff 4097.Jun 9 2018, 13:29

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

schancel accepted this revision.Jun 12 2018, 12:49

This revision is now accepted and ready to land.Jun 12 2018, 12:49

Closed by commit rABC49a8cb7b4e0a: Remove unecessary calls to GetSatoshis and Amount creation. (authored by deadalnix). · Explain WhyJun 12 2018, 12:52

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

amount.cpp

8 lines

primitives/

transaction.cpp

8 lines

rpc/

server.cpp

9 lines

script/

interpreter.cpp

2 lines

test/

amount_tests.cpp

4 lines

validation.cpp

6 lines

Diff 4108

View Options

src/amount.cpp

View Options

src/primitives/transaction.cpp

View Options

src/rpc/server.cpp

View Options

src/script/interpreter.cpp

View Options

src/test/amount_tests.cpp

View Options

Remove unecessary calls to GetSatoshis and Amount creation.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4108

src/amount.cpp

src/primitives/transaction.cpp

src/rpc/server.cpp

src/script/interpreter.cpp

src/test/amount_tests.cpp

src/validation.cpp

Remove unecessary calls to GetSatoshis and Amount creation.
ClosedPublic
Actions

Revision Contents
Changeset List