[electrum] typehints and minor cleanup in interface.py
ClosedPublic
Actions

Authored by PiRK on Dec 7 2023, 21:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC40e6b84392b8: [electrum] typehints and minor cleanup in interface.py

Summary

This is a code cleanup to help me better understand the network.py code.

Add typehints where the IDE cannot guees the type.
Use an Enum for interface modes for better type-safety and more helpful IDE assistance.
Remove an unused TCPConnection.protocol attribute.
Use the more modern NamedTuple class definition.

Test Plan

python test_runner.py
python -m electrumabc.interface
pytest electrumabc/tests/regtest

Run the application, check the network dialog, change the server.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25882
Build 51340: Build Diff	electrum-tests
Build 51339: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 7 2023, 21:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2023, 21:00

PiRK requested review of this revision.Dec 7 2023, 21:00

PiRK edited the test plan for this revision. (Show Details)Dec 7 2023, 21:01

Harbormaster completed remote builds in B25881: Diff 43495.Dec 7 2023, 21:02

PiRK edited the summary of this revision. (Show Details)Dec 7 2023, 21:02

remove comment that is made useless by using explicit args

Harbormaster completed remote builds in B25882: Diff 43496.Dec 7 2023, 21:11

PiRK added inline comments.Dec 7 2023, 21:12

electrum/electrumabc/interface.py
381	And here I tried `Interface.Mode` or `self.Mode` for consistency with the above style, but neither one worked. `Mode` is in scope and works, though.
389	And here I tried `Interface.Mode` or `self.Mode` for consistency with the above style, but neither one worked. `Mode` is in scope and works, though.