Page MenuHomePhabricator

[electrum] define and annotate Interface attributes in __init__.py
ClosedPublic

Authored by PiRK on Dec 8 2023, 09:08.

Details

Summary

Monkey-patching the Interface instances in network.py with new attributes makes it hard to inspect the code and know what the attributes are. Declare them in Interface.__init__ and initialize the ones that were previously initialized immediately after instantiating the Interface

Depends on D14950

Test Plan
python test_runner.py
pytest electrumabc/tests/regtest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanup_network
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25891
Build 51358: Build Diffelectrum-tests
Build 51357: arc lint + arc unit