Differential D14957

[avalanche] Remote proofs: only account for the stake once when a peer has several nodes
ClosedPublic
Actions

Authored by Fabien on Dec 8 2023, 20:41.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf9a6b844b91d: [avalanche] Remote proofs: only account for the stake once when a peer has…

Summary

The current heuristic account for the stake for each node, so if several nodes belong to a single peer they are accounted several times. This is not in par with the polling selection algorithm, so let's update the heuristic so it gets closer.

Test Plan

ninja check-avalanche-peermanager_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 8 2023, 20:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2023, 20:41

Fabien requested review of this revision.Dec 8 2023, 20:41

Harbormaster completed remote builds in B25902: Diff 43526.Dec 8 2023, 21:07

Fabien added a child revision: D14958: [avalanche] Remote proofs: only account for the stakes.Dec 8 2023, 21:07

PiRK accepted this revision.Dec 10 2023, 17:56

This revision is now accepted and ready to land.Dec 10 2023, 17:56

Closed by commit rABCf9a6b844b91d: [avalanche] Remote proofs: only account for the stake once when a peer has… (authored by Fabien). · Explain WhyDec 11 2023, 08:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf9a6b844b91d: [avalanche] Remote proofs: only account for the stake once when a peer has….

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

13 lines

test/

peermanager_tests.cpp

27 lines

Diff 43537

View Options

src/avalanche/peermanager.cpp