Page MenuHomePhabricator

[avalanche] Let -maxavalancheoutbound takes precedence over -maxconnections
ClosedPublic

Authored by Fabien on Dec 12 2023, 10:32.

Details

Summary

And remove the -maxconnections option from the example config file. This options has led to several issues for avalanche users using it as a habit.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_conflicting_params
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25931
Build 51437: Build Diffbuild-without-wallet · build-clang-tidy · build-clang · build-diff · build-debug · lint-circular-dependencies
Build 51436: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Dec 12 2023, 10:32
PiRK added a subscriber: PiRK.
PiRK added inline comments.
doc/release-notes.md
14

if -maxavalancheoutbound is higher than -maxconnections

Not sure if this is worth mentioning. Maybe users will try reducing maxavalancheoutbound to limit the number of connections.

This revision is now accepted and ready to land.Dec 12 2023, 14:09
doc/release-notes.md
14

Yes that's the idea, you can still do it but you need both options.