[Cashtab] Improve multisend validation
ClosedPublic
Actions

Authored by bytesofman on Dec 13 2023, 18:36.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe9366b58c957: [Cashtab] Improve multisend validation

Summary

Improve validation functions supporting xec multisend.

Do not .split() more than once
Do not accept decimal markers other than '.'
Throw error if more than one comma per line in expected csv input
Do not accept non-digit characters for value input (except '.')

Note: I did not add a check against very large values, as it is still safe in JS to multiple the total supply of XEC by 100. So, I think it's overkill to check for this every time.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

better-multisend-validation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25957
Build 51489: Build Diff	cashtab-tests
Build 51488: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 13 2023, 18:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2023, 18:36

bytesofman requested review of this revision.Dec 13 2023, 18:36

bytesofman mentioned this in D14976: [Cashtab] Add function to generate targetOutputs for multisend tx from user input.Dec 13 2023, 18:37

Harbormaster completed remote builds in B25956: Diff 43608.Dec 13 2023, 18:39

all of the snapshots is a bit much even though jest recommends including them. In this diff -- you can see that a css class has changed, which is consistent with changing a css rule on a shared component.

cashtab/src/components/Common/EnhancedInputs.js
115 ↗	(On Diff #43608)	UX goal here is for all error msgs to fit on one line

remove debug logging

Harbormaster completed remote builds in B25957: Diff 43609.Dec 13 2023, 18:43

PiRK accepted this revision.Dec 14 2023, 08:06

PiRK added a subscriber: PiRK.

PiRK added inline comments.

cashtab/src/utils/validation.js

505–519

Depending on how much you like complicated regular expressions, it could be possible to do both checks in one regex: https://stackoverflow.com/a/12643073/4494781

^([0-9]+([.][0-9]*)?|[.][0-9]+)$

>>> import re
>>> rg = "^([0-9]+([.][0-9]*)?|[.][0-9]+)$"
>>>
>>> re.match(rg, "123a34") != None
False
>>> re.match(rg, "123.34") != None
True
>>> re.match(rg, ".34") != None
True
>>> re.match(rg, "123.") != None
True
>>> re.match(rg, "123.1.2") != None
False
>>> re.match(rg, "123") != None
True

or if you don't care to match "123." this one is simpler:

^([0-9]*[.])?[0-9]+$

This revision is now accepted and ready to land.Dec 14 2023, 08:06

bytesofman added inline comments.Dec 14 2023, 18:40

cashtab/src/utils/validation.js
505–519	`/^([0-9]+([.][0-9]*)?\|[.][0-9]+)$/.test('123.12345')` `> true` seems to work, but in this case we want to reject values with more than 2 decimal places. Since `parseFloat` is the method eventually applied to the input to build the tx, I think for now best to use it in the validation check as well.