test: Fix intermittent failure in ChainStateManager tests
ClosedPublic
Actions

Authored by PiRK on Dec 14 2023, 12:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC540195703a20: test: Fix intermittent failure in ChainStateManager tests

Summary

Before wiping the ChainStateManager, the validationinterface queue must be drained to avoid accessing deleted memory.

This is a backport of core#27348

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 14 2023, 12:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 14 2023, 12:04

PiRK requested review of this revision.Dec 14 2023, 12:04

teamcity edited the summary of this revision. (Show Details)Dec 14 2023, 12:04

Fabien accepted this revision.Dec 14 2023, 12:09

This revision is now accepted and ready to land.Dec 14 2023, 12:09

Harbormaster completed remote builds in B25961: Diff 43614.Dec 14 2023, 12:21

Closed by commit rABC540195703a20: test: Fix intermittent failure in ChainStateManager tests (authored by Martin Zumsande <mzumsande@gmail.com>, committed by PiRK). · Explain WhyDec 14 2023, 12:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC540195703a20: test: Fix intermittent failure in ChainStateManager tests.

Revision Contents
Changeset List

Path

Size

src/

test/

validation_chainstatemanager_tests.cpp

6 lines

Diff 43615

View Options

src/test/validation_chainstatemanager_tests.cpp

test: Fix intermittent failure in ChainStateManager testsClosedPublicActions