Page MenuHomePhabricator

Make static nLastFlush and nLastWrite Chainstate members
ClosedPublic

Authored by PiRK on Dec 18 2023, 09:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC6842022c6059: Make static nLastFlush and nLastWrite Chainstate members
Summary

Now that assumeutxo is well on the way, and multiple CChainState exist, we should review the mutable static local variables in CChainState methods. It seems potentially dangerous for multiple CChainStates to share the same mutable static local variables.

ref T3378

This is a backport of core#26513
Depends on D15001

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable