prune, import: allows pruning to work during the loadblock import process
ClosedPublic
Actions

Authored by PiRK on Dec 18 2023, 15:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2c2af694406a: prune, import: allows pruning to work during the loadblock import process

Summary

allows pruning to work during the loadblock import process.

This is a backport of core#24957

Depends on D15003

Test Plan

Backup the eCash data dir, create a bootstrap.dat file by following the instructions in contrib/linearize, then delete the content of the data dir, comment out config options that are incompatible with pruning (txindex=1) then
src/bitcoind -prune=550 -loadblock=/data/bootstrap.dat

Check while the node is importing the blocks from bootstrap.dat that the new data dir does not grow significantly larger than 550 MB (I saw it oscillates between that target and 800 MB, while the bootstrap.dat file was 21 GB of blocks 0--313000)

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 18 2023, 15:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2023, 15:01

PiRK requested review of this revision.Dec 18 2023, 15:01

teamcity edited the summary of this revision. (Show Details)Dec 18 2023, 15:01

I didn't wait long enough, now the size is 1.3 GB around block 275000. I need to check if this is normal behavior when pruning.

PiRK retitled this revision from prune, import: fixes #23852 to prune, import: allows pruning to work during the loadblock import process.Dec 18 2023, 15:15

Harbormaster completed remote builds in B25988: Diff 43658.Dec 18 2023, 15:18

The blocks dir stayed below the prune target. The extra 700MB is for the chainstate data.

Fabien accepted this revision.Dec 19 2023, 08:27

Fabien added a subscriber: Fabien.

Fabien added inline comments.