Differential D1500

Move get_srcdir to where it is used
ClosedPublic
Actions

Authored by schancel on Jun 13 2018, 10:29.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING37fb1629e725: Move get_srcdir to where it is used
rABC37fb1629e725: Move get_srcdir to where it is used

Summary

Move get_srcdir function to cdefs.py, it's only
usage location.

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

src_dir

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2734
Build 3579: Bitcoin ABC Buildbot (legacy)
Build 3578: arc lint + arc unit

Event Timeline

schancel created this revision.Jun 13 2018, 10:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2018, 10:29

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2734: Diff 4112.Jun 13 2018, 11:07

jasonbcox requested changes to this revision.Jun 13 2018, 21:11

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

test/functional/test_framework/cdefs.py
23	Remove this line ;)

This revision now requires changes to proceed.Jun 13 2018, 21:11

schancel added inline comments.Jun 15 2018, 11:19

test/functional/test_framework/cdefs.py
23	Please approve and note for requests like this.

Remove TODO comment

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2743: Diff 4126.Jun 15 2018, 11:58

jasonbcox accepted this revision.Jun 15 2018, 17:07

This revision is now accepted and ready to land.Jun 15 2018, 17:07

Closed by commit rABC37fb1629e725: Move get_srcdir to where it is used (authored by schancel). · Explain WhyJun 18 2018, 13:20

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

cdefs.py

46 lines

util.py

45 lines

Diff 4112

View Options

test/functional/test_framework/cdefs.py