Paths

Table of Contentst

Differential D15030

[Chronik] Don't ignore SLP and ALP mixups when parsing
ClosedPublic
Actions

Authored by tobias_ruck on Dec 21 2023, 16:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5277980ab6a4: [Chronik] Don't ignore SLP and ALP mixups when parsing

Summary

Users may accidentally use SLP in eMPP, or forget to use OP_RESERVED when using ALP, both of which currently silently get ignored when parsing.

However, it would be more helpful to return an error in this case so they know exactly what went wrong.

Test Plan

cargo test -p bitcoinsuite-slp

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Dec 21 2023, 16:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2023, 16:32

tobias_ruck requested review of this revision.Dec 21 2023, 16:32

Harbormaster completed remote builds in B26045: Diff 43743.Dec 21 2023, 16:51

tobias_ruck added a child revision: D15033: [Chronik] Add `ColoredTx` to `bitcoinsuite-slp`.Dec 22 2023, 00:18

Fabien accepted this revision.Dec 22 2023, 08:44

This revision is now accepted and ready to land.Dec 22 2023, 08:44

Closed by commit rABC5277980ab6a4: [Chronik] Don't ignore SLP and ALP mixups when parsing (authored by tobias_ruck). · Explain WhyDec 22 2023, 11:50

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC5277980ab6a4: [Chronik] Don't ignore SLP and ALP mixups when parsing.

Revision Contents
Changeset List

Path

Size

chronik/

bitcoinsuite-slp/

src/

alp/

parse.rs

9 lines

slp/

error.rs

5 lines

parse.rs

4 lines

tests/

test_alp_parse_common.rs

16 lines

test_slp_parse_common.rs

22 lines

Diff 43765

View Options

chronik/bitcoinsuite-slp/src/alp/parse.rs

View Options

chronik/bitcoinsuite-slp/src/slp/error.rs

View Options

chronik/bitcoinsuite-slp/src/slp/parse.rs

View Options

chronik/bitcoinsuite-slp/tests/test_alp_parse_common.rs

View Options

chronik/bitcoinsuite-slp/tests/test_slp_parse_common.rs

[Chronik] Don't ignore SLP and ALP mixups when parsingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43765

chronik/bitcoinsuite-slp/src/alp/parse.rs

chronik/bitcoinsuite-slp/src/slp/error.rs

chronik/bitcoinsuite-slp/src/slp/parse.rs

chronik/bitcoinsuite-slp/tests/test_alp_parse_common.rs

chronik/bitcoinsuite-slp/tests/test_slp_parse_common.rs

[Chronik] Don't ignore SLP and ALP mixups when parsing
ClosedPublic
Actions

Revision Contents
Changeset List