Page MenuHomePhabricator

[Chronik] Format Rust code with the latest nightly + update CI
ClosedPublic

Authored by tobias_ruck on Dec 28 2023, 20:02.

Details

Summary

Previously, let-else wasn't formatted at all, because the formatter didn't support it.

Users trying to push code with the latest formatter will have arcanist complain, so we format the code and update the CI to the latest nightly version.

Test Plan

arc lint

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-fmt-nightly
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26073
Build 51719: Build Diffchronik-client-integration-tests · build-chronik
Build 51718: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Dec 29 2023, 14:21

You need to bump the CI nightly version as well (install-dependencies-bullseye.sh)

This revision now requires changes to proceed.Dec 29 2023, 14:21

update install-dependencies-bullseye.sh

This revision is now accepted and ready to land.Dec 30 2023, 21:00
tobias_ruck retitled this revision from [Chronik] Format Rust code with the latest nightly to [Chronik] Format Rust code with the latest nightly + update CI.Dec 30 2023, 21:09
tobias_ruck edited the summary of this revision. (Show Details)