Remove IsValidDestinationString overload that doesn't use a Config parameter.
ClosedPublic
Actions

Authored by deadalnix on Jun 18 2018, 16:05.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING5fcb655b8ca6: Remove IsValidDestinationString overload that doesn't use a Config parameter.
rABC5fcb655b8ca6: Remove IsValidDestinationString overload that doesn't use a Config parameter.

Summary

This is one more step toward getting rid of the config as a global parameter.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 18 2018, 16:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 18 2018, 16:05

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2749: Diff 4134.Jun 18 2018, 16:42

jasonbcox accepted this revision.Jun 18 2018, 16:43

This revision is now accepted and ready to land.Jun 18 2018, 16:43

Closed by commit rABC5fcb655b8ca6: Remove IsValidDestinationString overload that doesn't use a Config parameter. (authored by deadalnix). · Explain WhyJun 18 2018, 23:27

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

dstencode.h

1 line

dstencode.cpp

8 lines

qt/

bitcoinaddressvalidator.cpp

4 lines

7 lines

3 lines

2 lines

7 lines

Diff 4144

View Options

src/dstencode.h

View Options

src/dstencode.cpp

View Options

src/qt/bitcoinaddressvalidator.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/walletmodel.h

View Options

Remove IsValidDestinationString overload that doesn't use a Config parameter.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4144

src/dstencode.h

src/dstencode.cpp

src/qt/bitcoinaddressvalidator.cpp

src/qt/guiutil.cpp

src/qt/paymentserver.cpp

src/qt/walletmodel.h

src/qt/walletmodel.cpp

Remove IsValidDestinationString overload that doesn't use a Config parameter.
ClosedPublic
Actions

Revision Contents
Changeset List