New function to generate targetOutputs for slpv1 send txs
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCd5f3b2978f10: [Cashtab] Get outputs for SLP v1 send txs
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- slp-send-helper-fn
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26128 Build 51829: Build Diff cashtab-tests Build 51828: arc lint + arc unit
Event Timeline
Comment Actions
TODO
- Add unit tests based on new txs
- Review for where this function will fit in. Will you also need a function to determine tokenUtxos ? Where will this function be called? May want to combine this here, i.e. accept wallet, tokenId as params.
Comment Actions
It's possible this function will change when I go to implement it, and work out the structure of how utxos will be selected for slpv1 transactions (mb ecash-coinselect is the best place to do this?). However, something very close to this function will be needed to deprecate the existing functions. So getting this in with the unit tests (based on broadcast slp txs) is a good starting point.
| cashtab/package.json | ||
|---|---|---|
| 41 ↗ | (On Diff #43859) | this upgrade is required to use the toLegacy function |