[herald] Print ascii string for unknown miners with well-pushed ascii in coinbase
ClosedPublic
Actions

Authored by bytesofman on Jan 4 2024, 19:45.

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rABC0cda9f4d06d8: [herald] Print ascii string for unknown miners with well-pushed ascii in…

Summary

Parse new miner(s) first observed at block 825737.

This could be a new pool, or a new miner, or simply a pattern that happens to fit some recently observed blocks. Either way, it is an improvement on calling them all 'unknown'.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-parse-eku

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26213
Build 51998: Build Diff	ecash-herald-tests
Build 51997: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 4 2024, 19:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2024, 19:45

bytesofman published this revision for review.Jan 4 2024, 19:45

Harbormaster completed remote builds in B26154: Diff 43900.Jan 4 2024, 19:46

Let's wait at least for another block as the eku4 could really be random data that ended up being ascii

This revision now requires changes to proceed.Jan 4 2024, 21:22

Unknown Object (User) added a subscriber: Unknown Object (User).Jan 5 2024, 05:46

This comment was removed by Fabien.

More generalized processing for certain type of unknown miner

Harbormaster completed remote builds in B26213: Diff 43989.Jan 9 2024, 15:06

bytesofman retitled this revision from [herald] Parse eku4 miner to [herald] Print ascii string for unknown miners with well-pushed ascii in coinbase.Jan 9 2024, 15:06

bytesofman edited the summary of this revision. (Show Details)

remove debug logging

Harbormaster completed remote builds in B26214: Diff 43990.Jan 9 2024, 15:08

bytesofman added a child revision: D15113: [herald] Patch bug in unidentified miner.Jan 9 2024, 15:15

Fabien accepted this revision.Jan 10 2024, 09:38

This revision is now accepted and ready to land.Jan 10 2024, 09:38

Closed by commit rABC0cda9f4d06d8: [herald] Print ascii string for unknown miners with well-pushed ascii in… (authored by bytesofman). · Explain WhyJan 10 2024, 13:22

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC0cda9f4d06d8: [herald] Print ascii string for unknown miners with well-pushed ascii in….

Unknown Object (User) removed reviewers: Restricted Project, Fabien.Mar 15 2024, 07:16

Unknown Object (User) added a subscriber: Unknown Object (User).

This comment was removed by Fabien.