Page MenuHomePhabricator
Differential D15109

[addrman] add tests for IsTerrible
ClosedPublic
Actions

Authored by PiRK on Jan 8 2024, 09:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC82bbd1c2dcf0: [addrman] add tests for IsTerrible
Summary

The review of D15095 revealed that this function is not tested. Add tests to catch potential mistakes when that function is touched.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 8 2024, 09:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2024, 09:57
PiRK requested review of this revision.Jan 8 2024, 09:57
Fabien accepted this revision.Jan 8 2024, 10:18
This revision is now accepted and ready to land.Jan 8 2024, 10:18
Harbormaster completed remote builds in B26204: Diff 43973.Jan 8 2024, 10:23
Closed by commit rABC82bbd1c2dcf0: [addrman] add tests for IsTerrible (authored by PiRK). · Explain WhyJan 8 2024, 10:41
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC82bbd1c2dcf0: [addrman] add tests for IsTerrible.

Revision Contents
Changeset List

PathSize
src/
test/
86 lines

Diff 43974

View Options

src/test/addrman_tests.cpp

Loading...