Page MenuHomePhabricator
Differential D15114

[herald] Abbreviate some replayed memo msgs
ClosedPublic
Actions

Authored by bytesofman on Jan 9 2024, 16:31.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC7d517b9e363a: [herald] Abbreviate some replayed memo msgs
Summary

Most memo txs are replayed on BCH, and some are clearly not XEC related.

Abbreviate these in ecash-herald.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
trim-memo-msgs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26219
Build 52010: Build Diffecash-herald-tests
Build 52009: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 9 2024, 16:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 9 2024, 16:31
bytesofman requested review of this revision.Jan 9 2024, 16:31
bytesofman added a comment.Jan 9 2024, 16:32

before

image.png (168×621 px, 38 KB)

after

image.png (73×363 px, 8 KB)

Harbormaster completed remote builds in B26219: Diff 43995.Jan 9 2024, 16:32
emack accepted this revision.Jan 10 2024, 03:56
emack added a subscriber: emack.

Ok for now but need to keep a note somewhere to revert this when/if we implement memo cash for XEC, at which point users should be able to mention BCH and have it show up on the herald.

This revision is now accepted and ready to land.Jan 10 2024, 03:56
Closed by commit rABC7d517b9e363a: [herald] Abbreviate some replayed memo msgs (authored by bytesofman). · Explain WhyJan 10 2024, 13:21
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC7d517b9e363a: [herald] Abbreviate some replayed memo msgs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
4 lines

Diff 43995

View Options

apps/ecash-herald/src/parse.js

Loading...