Improve logic of handleAddressChange function on Send screen
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCddba347572ea: [Cashtab] Improve Send screen handling of address input
npm test
Edit config/alias.js to set aliasEnabled to true
Navigate to the send screen and test validation for following strings
ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6 (valid address), no error msg
ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg (invalid address and invalid alias), error msg 'invalid alias'
ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6?amount=100 (valid address with param), no error msg
chicken.xec (valid alias), alias address displayed under input field
chicken.xe (invalid alias input), error msg 'invalid address'
chicken.xec?amount=100 (valid address with param)
chicken999999999999.xec (valid but unregistered alias), error msg 'alias not registered'
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- better-send-addr-validation
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26226 Build 52024: Build Diff cashtab-tests Build 52023: arc lint + arc unit
Event Timeline
Comment Actions
test plan screenshots
ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6 (valid address), no error msg
ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg (invalid address and invalid alias), error msg 'invalid alias'
ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6?amount=100 (valid address with param), no error msg
chicken.xec (valid alias), alias address displayed under input field
chicken.xe (invalid alias input), error msg 'invalid address'
chicken.xec?amount=100 (valid address with param)
chicken999999999999.xec (valid but unregistered alias), error msg 'alias not registered'
chicken999999999999.xec?amount=100 (param is parsed but still have address error msg)
| cashtab/src/components/Send/Send.js | ||
|---|---|---|
| 460–461 | point of the diff better logic organization so we avoid setting and then unsetting this error | |