Page MenuHomePhabricator

qt: Revamp ClientModel code to handle core signals
ClosedPublic

Authored by PiRK on Jan 10 2024, 15:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd21c7c6ccbeb: qt: Revamp ClientModel code to handle core signals
Summary

This is a pure refactoring with no behavior change:

  • gets rid of QMetaObject::invokeMethod() "dynamic" calls, i.e., without compile-time checks of a called function name and its parameters
  • replaces std::binds with lambdas, making parameter permutation (including parameter omitting) explicit
  • makes code simpler, more concise, and easier to reason about

This is a backport of core-gui#581

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable