HomePhabricator

qt: Revamp ClientModel code to handle core signals

Description

qt: Revamp ClientModel code to handle core signals

Summary:
This is a pure refactoring with no behavior change:

  • gets rid of QMetaObject::invokeMethod() "dynamic" calls, i.e., without compile-time checks of a called function name and its parameters
  • replaces std::binds with lambdas, making parameter permutation (including parameter omitting) explicit
  • makes code simpler, more concise, and easier to reason about

This is a backport of core-gui#581

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15131

Details

Provenance
Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>Authored on Apr 10 2022, 15:39
PiRKCommitted on Jan 11 2024, 07:33
PiRKPushed on Jan 11 2024, 07:33
Reviewer
Restricted Project
Differential Revision
D15131: qt: Revamp ClientModel code to handle core signals
Parents
rABCe86706f249a1: [Cashtab] Add missing dep to dev deps
Branches
Unknown
Tags
Unknown