Page MenuHomePhabricator

wallet: Make -wallet setting not create wallets
ClosedPublic

Authored by PiRK on Jan 12 2024, 13:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7321d7539797: wallet: Make -wallet setting not create wallets
Summary

This changes -wallet setting to only load existing wallets, not create new ones.

  • Simplifies behavior after #15454. #15454 took the big step of disabling creation of the default wallet. This PR extends it to avoid creating other wallets as well. With this change, new wallets just aren't created on startup, instead of sometimes being created, sometimes not. #15454 release notes are updated here and are simpler.

It is a bug fix and simplifies behavior of the core#15937 / core#19754 / core#15454 features

This is a backport of core#20186

Depends on D15143 and D14142

Test Plan

ninja all check-all

With bitcoin-qt, create and load a wallet, close the program. In the file explorer rename the wallet directory. Restart bitcoin-qt and check that now the old wallet name is not recreated (in addition to the wallet with the new name) but an error message warns about it not being found. The new wallet name is now the only wallet avaialble.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jan 12 2024, 13:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
13–15 ↗(On Diff #44089)

The newline is not necessary imo

This revision is now accepted and ready to land.Jan 12 2024, 13:53