Page MenuHomePhabricator

[Cashtab] Show timeFirstSeen in tx history
ClosedPublic

Authored by bytesofman on Jan 14 2024, 00:41.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC54de1cba29c5: [Cashtab] Show timeFirstSeen in tx history
Summary

It's useful to know the time of a tx to higher resolution than 24 hrs. Show this info when a user clicks a tx to expand for more info.

Test Plan

npm start, navigate to tx history screen, click on a tx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
use-timefirstseen
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26341
Build 52252: Build Diffcashtab-tests
Build 52251: arc lint + arc unit

Event Timeline

seconds instead of s in comment

image.png (384×471 px, 37 KB)

note that time (format depending on browser locale) is visible on expanded txs in history

emack requested changes to this revision.Jan 14 2024, 04:24
emack added a subscriber: emack.

Isn't it better to just render this on the default tx history element state? Are there any advantages to making the user click into it to see the time? There's plenty of space for it.

This revision now requires changes to proceed.Jan 14 2024, 04:24

Isn't it better to just render this on the default tx history element state? Are there any advantages to making the user click into it to see the time? There's plenty of space for it.

hm good point. it's a judgment call, I like that you get more info if you expand the tx, don't want to show too much for every tx by default. I dunno if you really need to know tx time down to the second by default.

But, it is pretty cool that we have that info.

Patched it to start that way. If it looks to crowded we can add in the state stuff later.

This revision is now accepted and ready to land.Jan 14 2024, 04:56