Paths

Table of Contentst

Differential D15163

fuzz: Introduce CallOneOf helper to replace switch-case
ClosedPublic
Actions

Authored by PiRK on Jan 15 2024, 11:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc42127bc3ced: fuzz: Introduce CallOneOf helper to replace switch-case

Summary

Can be reviewed with --ignore-all-space

This is a backport of core#20828

Test Plan

ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26354
Build 52278: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-clang-tidy · build-debug · build-clang
Build 52277: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 15 2024, 11:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2024, 11:37

PiRK requested review of this revision.Jan 15 2024, 11:37

teamcity edited the summary of this revision. (Show Details)Jan 15 2024, 11:38

Harbormaster completed remote builds in B26349: Diff 44166.Jan 15 2024, 11:54

Fabien requested changes to this revision.Jan 15 2024, 13:11

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/fuzz/crypto.cpp
40 ↗	(On Diff #44166)	That's not from this PR
src/test/fuzz/util.h
335 ↗	(On Diff #44166)	you might want to turn clang-format off here

This revision now requires changes to proceed.Jan 15 2024, 13:11

revert unrelated changes in crypto.cpp, disable clang-format for a couple of CallOneOf calls

Harbormaster completed remote builds in B26354: Diff 44176.Jan 15 2024, 14:04

Fabien accepted this revision.Jan 15 2024, 17:11

This revision is now accepted and ready to land.Jan 15 2024, 17:11

Closed by commit rABCc42127bc3ced: fuzz: Introduce CallOneOf helper to replace switch-case (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 16 2024, 08:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc42127bc3ced: fuzz: Introduce CallOneOf helper to replace switch-case.

Revision Contents
Changeset List

Path

Size

src/

test/

fuzz/

34 lines

54 lines

30 lines

31 lines

90 lines

88 lines

69 lines

29 lines

crypto_chacha20_poly1305_aead.cpp

48 lines

net.cpp

35 lines

rolling_bloom_filter.cpp

20 lines

39 lines

72 lines

65 lines

46 lines

155 lines

Diff 44176

View Options

src/test/fuzz/autofile.cpp

View Options

src/test/fuzz/banman.cpp

View Options

src/test/fuzz/bloom_filter.cpp

View Options

src/test/fuzz/buffered_file.cpp

View Options

src/test/fuzz/coins_view.cpp

View Options

src/test/fuzz/connman.cpp

View Options

src/test/fuzz/crypto.cpp

View Options

src/test/fuzz/crypto_chacha20.cpp

View Options

src/test/fuzz/crypto_chacha20_poly1305_aead.cpp

View Options

src/test/fuzz/net.cpp

View Options

src/test/fuzz/rolling_bloom_filter.cpp

View Options

src/test/fuzz/script_ops.cpp

View Options

src/test/fuzz/scriptnum_ops.cpp

View Options

src/test/fuzz/strprintf.cpp

View Options

src/test/fuzz/system.cpp

View Options

fuzz: Introduce CallOneOf helper to replace switch-caseClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44176

src/test/fuzz/autofile.cpp

src/test/fuzz/banman.cpp

src/test/fuzz/bloom_filter.cpp

src/test/fuzz/buffered_file.cpp

src/test/fuzz/coins_view.cpp

src/test/fuzz/connman.cpp

src/test/fuzz/crypto.cpp

src/test/fuzz/crypto_chacha20.cpp

src/test/fuzz/crypto_chacha20_poly1305_aead.cpp

src/test/fuzz/net.cpp

src/test/fuzz/rolling_bloom_filter.cpp

src/test/fuzz/script_ops.cpp

src/test/fuzz/scriptnum_ops.cpp

src/test/fuzz/strprintf.cpp

src/test/fuzz/system.cpp

src/test/fuzz/util.h

fuzz: Introduce CallOneOf helper to replace switch-case
ClosedPublic
Actions

Revision Contents
Changeset List