Page MenuHomePhabricator
Differential D15170

Make validation interface capable of signalling header presync
ClosedPublic
Actions

Authored by PiRK on Jan 15 2024, 14:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC43da00046c4e: Make validation interface capable of signalling header presync
Summary

This makes a number of changes:

  • Get rid of the verification_progress argument in the node interface NotifyHeaderTip (it was always 0.0).
  • Instead of passing a CBlockIndex* in the UI interface's NotifyHeaderTip, send separate height, timestamp fields. This is becuase in headers presync, no actual CBlockIndex object is available.
  • Add a bool presync argument to both of the above, to identify signals pertaining to the first headers sync phase.

Emit NotifyHeaderTip signals for pre-synchronization progress

This is a partial backport of core#25717
https://github.com/bitcoin/bitcoin/pull/25717/commits/376086fc5a187f5b2ab3a0d1202ed4e6c22bdb50
https://github.com/bitcoin/bitcoin/pull/25717/commits/738421c50f2dbd7395b50a5dbdf6168b07435e62

Depends on D15169

Test Plan

ninja all check-all

Run a header sync on main net

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 15 2024, 14:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2024, 14:07
PiRK requested review of this revision.Jan 15 2024, 14:07
teamcity edited the summary of this revision. (Show Details)Jan 15 2024, 14:07
PiRK updated this revision to Diff 44186.Jan 15 2024, 14:10
PiRK edited the summary of this revision. (Show Details)

squash with the next commit, these two are related

Harbormaster completed remote builds in B26363: Diff 44185.Jan 15 2024, 14:57
Harbormaster completed remote builds in B26364: Diff 44186.Jan 15 2024, 15:05
PiRK added a child revision: D15172: ui: show header pre-synchronization progress.Jan 15 2024, 17:09
Fabien added a subscriber: Fabien.Jan 15 2024, 19:51

@bot build-chronik

teamcity awarded a token.Jan 15 2024, 19:51
Fabien accepted this revision.Jan 15 2024, 20:13
This revision is now accepted and ready to land.Jan 15 2024, 20:13
Closed by commit rABC43da00046c4e: Make validation interface capable of signalling header presync (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyJan 16 2024, 08:12
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC43da00046c4e: Make validation interface capable of signalling header presync.

Revision Contents
Changeset List

PathSize
src/
interfaces/
5 lines
node/
8 lines
2 lines
6 lines
qt/
7 lines
8 lines

Diff 44235

View Options

src/interfaces/node.h

Loading...
View Options

src/node/interfaces.cpp

Loading...
View Options

src/node/ui_interface.h

Loading...
View Options

src/node/ui_interface.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/validation.cpp

Loading...