Page MenuHomePhabricator

[Cashtab] Add more wallet helper functions
ClosedPublic

Authored by bytesofman on Jan 18 2024, 19:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf9deb6ee1f14: [Cashtab] Add more wallet helper functions
Summary

Add standardized toXec and toSatoshis functions. Cashtab has iterated through too many of these functions. They should be simple, tested, and live in one place.

For now -- just use the BigNumber library, as this can't be deprecated for some time.

This diff does not implement the functions. This is part of a series of diffs working to standardize balance headers in Cashtab and remove functions from utils.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
new-wallet-fns
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26472
Build 52514: Build Diffcashtab-tests
Build 52513: arc lint + arc unit

Event Timeline

Fabien retitled this revision from [Cashtab] Add more wallet helper fns to [Cashtab] Add more wallet helper functions.Jan 18 2024, 20:15

rebase and add error validation + tests

This revision is now accepted and ready to land.Jan 18 2024, 21:02