[chronik-client] Do not try next server if error is unrelated to server outage
ClosedPublic
Actions

Authored by bytesofman on Jan 19 2024, 16:32.

Details

Reviewers

Fabien
emack

Group Reviewers

Restricted Project

Commits

rABCfbdbdc16ae0f: [chronik-client] Do not try next server if error is unrelated to server outage

Summary

chronik-client is treating legitimate errors as server connection errors (for example, trying to get a block that does not exist, or a tx that fails to broadcast in NNG)

Server connection errors have a code key while chronik method errors do not. Use this instead of a string check which conflicts with other types of chronik errors.

This supersedes D15150

Test Plan

See test plan in D14915 or let CI build it. Ref draft D15210 which tests this against a method where chronik is expected to fail for non-server reasons.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 19 2024, 16:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2024, 16:32

bytesofman published this revision for review.Jan 19 2024, 16:32

bytesofman edited the summary of this revision. (Show Details)

bytesofman mentioned this in D15150: [chronik-client] Do not treat node reject tx error as chronik server connection error.

Harbormaster completed remote builds in B26489: Diff 44363.Jan 19 2024, 16:36

bytesofman mentioned this in D15210: [chronik-client] Add block and blocks methods to in-node chronik-client.Jan 19 2024, 18:13

bytesofman added a child revision: D15210: [chronik-client] Add block and blocks methods to in-node chronik-client.Jan 19 2024, 18:13

Fabien requested changes to this revision.Jan 19 2024, 21:09

Fabien added a subscriber: Fabien.

Fabien added inline comments.

modules/chronik-client/README.md
88 ↗	(On Diff #44363)	? This is not from this diff

This revision now requires changes to proceed.Jan 19 2024, 21:09

bytesofman added inline comments.Jan 19 2024, 23:44

modules/chronik-client/README.md
88 ↗	(On Diff #44363)	D15214

bytesofman requested review of this revision.Jan 19 2024, 23:45

emack requested changes to this revision.Jan 20 2024, 10:48

emack added a subscriber: emack.

emack added inline comments.

modules/chronik-client/README.md
88 ↗	(On Diff #44363)	Remove and then rebase to D15214
modules/chronik-client/src/failoverProxy.ts
132 ↗	(On Diff #44363)	'endpoint failures' sounds like server outage which initially got me confused why you were not checking for the absence of 'code'. 'Method errors' would be a better term here.