Paths

Table of Contentst

Differential D15217

[Cashtab] Replace cashMethods toSatoshis with new wallet toSatoshis
ClosedPublic
Actions

Authored by bytesofman on Jan 20 2024, 00:49.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCc2e8013d3ea5: [Cashtab] Replace cashMethods toSatoshis with new wallet toSatoshis

Summary

Continue to eat away at cashMethods.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecate-old-helpers

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26505
Build 52580: Build Diff	cashtab-tests
Build 52579: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 20 2024, 00:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2024, 00:49

Harbormaster completed remote builds in B26505: Diff 44380.Jan 20 2024, 00:52

bytesofman added a child revision: D15218: [Cashtab] Deprecate all duplicated legacy implementations of toXec and toSatoshis.Jan 20 2024, 01:31

bytesofman published this revision for review.Jan 20 2024, 01:34

emack accepted this revision.Jan 20 2024, 11:25

This revision is now accepted and ready to land.Jan 20 2024, 11:25

Closed by commit rABCc2e8013d3ea5: [Cashtab] Replace cashMethods toSatoshis with new wallet toSatoshis (authored by bytesofman). · Explain WhyJan 21 2024, 00:30

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc2e8013d3ea5: [Cashtab] Replace cashMethods toSatoshis with new wallet toSatoshis.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Send/

SendXec.js

7 lines

transactions/

index.js

2 lines

utils/

__tests__/

cashMethods.test.js

16 lines

cashMethods.js

12 lines

Diff 44380

View Options

cashtab/src/components/Send/SendXec.js

View Options

cashtab/src/transactions/index.js

View Options

cashtab/src/utils/tests/cashMethods.test.js

View Options

cashtab/src/utils/cashMethods.js

[Cashtab] Replace cashMethods toSatoshis with new wallet toSatoshisClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44380

cashtab/src/components/Send/SendXec.js

cashtab/src/transactions/index.js

cashtab/src/utils/__tests__/cashMethods.test.js

cashtab/src/utils/cashMethods.js

[Cashtab] Replace cashMethods toSatoshis with new wallet toSatoshis
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/utils/tests/cashMethods.test.js