Page MenuHomePhabricator

[Cashtab] Dep spring cleaning
AbandonedPublic

Authored by bytesofman on Jan 22 2024, 23:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Depends on D15241

Move dev dependencies to proper place. Move dev dependencies key immediately below dependencies key in package.json.

Delete dependencies:

bc-bip68 - must have been accidentally added while testing lock time
lodash.isempty - was once used with bch-api utxo org methods, should have been deleted when chronik implemented
lodash.isequal - same
long - used when chronik first introduced and numbers were of this type
tailwindscss - maybe this was tested at some point? probably a legacy dep that is no longer used after react and webpack upgrades
prompts - probably from original create react app before it was ejected
, lodash.isempty, lodash.isequal, long, tailwindscss, and prompts

Test Plan

npm run build

grep -r --exclude-dir={node_modules,build,coverage} 'bc-bip68' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'lodash.isempty' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'lodash.isequal' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'long' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'tailwindscss' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'prompts' and no output

Diff Detail

Repository
rABC Bitcoin ABC
Branch
depsjan22
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26568
Build 52706: Build Diffcashtab-tests
Build 52705: arc lint + arc unit

Event Timeline

bytesofman edited the test plan for this revision. (Show Details)
Fabien requested changes to this revision.Jan 23 2024, 08:49
Fabien added a subscriber: Fabien.

This is doing 3 things at a time, which makes this diff very hard to review:

  • Reorder the dependencies in the package.json
  • Update some versions
  • Remove some dependencies

Please split this diff so the reviewers can actually see the differences.

This revision now requires changes to proceed.Jan 23 2024, 08:49

superseded by D15248 stack

also tailwindcss actually was still being used, typo in test plan