Page MenuHomePhabricator

[Cashtab] Patch proptypes in BalanceHeader
ClosedPublic

Authored by bytesofman on Jan 24 2024, 00:17.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCe69469a48a4a: [Cashtab] Patch proptypes in BalanceHeader
Summary

lingering copypasta prop type and proptypes does not support | syntax for 'or'

If they are not required props, just use PropTypes.number, which supports null or undefined.

Test Plan

npm start and nothing in the dev console about invalid prop types

Note: proptypes are a dev tool, this doesn't impact the built app

Diff Detail

Repository
rABC Bitcoin ABC
Branch
proptype-fix-bh
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26604
Build 52778: Build Diffcashtab-tests
Build 52777: arc lint + arc unit