Do not use `LocalTestingSetup` in getarg_tests test file.
ClosedPublic
Actions

Authored by PiRK on Jan 24 2024, 14:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC524c5c09465f: Do not use `LocalTestingSetup` in getarg_tests test file.

Summary

Avoid using a test fixture in getarg_tests for better readability.

This is a backport of core#24375

Depends on D15263

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 24 2024, 14:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2024, 14:11

PiRK requested review of this revision.Jan 24 2024, 14:11

teamcity edited the summary of this revision. (Show Details)Jan 24 2024, 14:11

Harbormaster completed remote builds in B26611: Diff 44522.Jan 24 2024, 14:25

PiRK added a child revision: D15265: qt: Avoid crash on startup if int specified in settings.json.Jan 24 2024, 14:38

Fabien accepted this revision.Jan 24 2024, 14:42

This revision is now accepted and ready to land.Jan 24 2024, 14:42

Closed by commit rABC524c5c09465f: Do not use `LocalTestingSetup` in getarg_tests test file. (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhyJan 24 2024, 15:28

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC524c5c09465f: Do not use `LocalTestingSetup` in getarg_tests test file..

Revision Contents
Changeset List

Path

Size

src/

test/

getarg_tests.cpp

361 lines

Diff 44534

View Options

Do not use `LocalTestingSetup` in getarg_tests test file.ClosedPublicActions