Page MenuHomePhabricator

[e.cash] Update header for 2024
ClosedPublic

Authored by bytesofman on Jan 24 2024, 19:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb3a720827dfe: [e.cash] Update header for 2024
Summary

This repo had a headerArray with variable calc that was not being used. Implement it.

Run eslint --fix . to update all headers in repo.

Test Plan

Confirm change is only to commented headers and year is correct

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Jan 24 2024, 20:32
Fabien added a subscriber: Fabien.

This is wrong, it updates the headers of files that have not been changed in 2024

This revision now requires changes to proceed.Jan 24 2024, 20:32

use regexp to accept other years, add default template for current year for newly created files, make it 2024 for files edited just now

Fabien requested changes to this revision.Jan 25 2024, 08:28

Still not exactly what you want. Dates can (should) be ranges, see suggestions.

web/e.cash/.eslintrc.js
1 ↗(On Diff #44560)
web/e.cash/next.preview.js
1 ↗(On Diff #44560)
This revision now requires changes to proceed.Jan 25 2024, 08:28
bytesofman added inline comments.
web/e.cash/next.preview.js
1 ↗(On Diff #44560)

in this case the file was created in 2024. The original 2023 header was in error.

bytesofman marked an inline comment as done.

better regex

This revision is now accepted and ready to land.Jan 26 2024, 15:35
This revision was automatically updated to reflect the committed changes.