Differential D15283

Clarify the transaction validation result
ClosedPublic
Actions

Authored by Fabien on Jan 25 2024, 15:30.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC24372428c4b1: Clarify the transaction validation result

Summary

The TX_CONFLICT validation result is used in several places that are not related to tx conflict. This diff creates 2 new codes to avoid confusion, and actually use the TX_CONFLICT value when there is a conflict (instead of using a policy error value).

This will make it easier to spot the conflicting transaction and take action like storing them and polling via avalanche.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 25 2024, 15:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2024, 15:30

Fabien requested review of this revision.Jan 25 2024, 15:30

PiRK accepted this revision.Jan 25 2024, 15:36

This revision is now accepted and ready to land.Jan 25 2024, 15:36

Harbormaster completed remote builds in B26655: Diff 44592.Jan 25 2024, 15:46

Closed by commit rABC24372428c4b1: Clarify the transaction validation result (authored by Fabien). · Explain WhyJan 26 2024, 15:23

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC24372428c4b1: Clarify the transaction validation result.

Revision Contents
Changeset List

Path

Size

src/

consensus/

11 lines

net_processing.cpp

2 lines

10 lines

Diff 44631

src/consensus/validation.h

Loading...

src/net_processing.cpp

Loading...

src/validation.cpp

Loading...